Update nuopc/dmi drivers similar to standalone drivers#640
Closed
mhrib wants to merge 1 commit into
Closed
Conversation
eclare108213
requested changes
Oct 7, 2021
Contributor
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
Do you intend to update Icepack in this PR, or should that be removed?
Contributor
|
I think Icepack should not be changing. That needs to be fixed in the PR (or create a new clean PR). |
Contributor
Author
|
Ups. There should be no changes to icepack. I'll make a new PR and remove this one. |
Contributor
Author
|
Create a new PR instead: #641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #641
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Update nuopc/dmi drivers and align it as close as possible with standalone drivers. Also introduce optional "stop_now_cpl" alowing CICE to stop correctly in coupled mode after last history-write + restart+dump.
@mhrib
@apcraig @eclare108213
19 measured results of 19 total results
19 of 19 tests PASSED
0 of 19 tests PENDING
0 of 19 tests MISSING data
0 of 19 tests FAILED
Also tested on coupled HYCOM-CICE setup at DMI. I think this is the real test:-)